gimbal: fix unregister message subscription #2208
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We should unregister anything we have subscribed to when being destructed. Signed-off-by: Julian Oes <julian@oes.ch>
julianoes
force-pushed
the
pr-fix-gimbal-heap-bug
branch
from
1d94390 to
5157b1a
Compare
Comment on lines
+24
to
+26
| _is_mavlink_manager_status_registered = false; | ||
|
|
||
| _system_impl.unregister_mavlink_message_handler(MAVLINK_MSG_ID_GIMBAL_MANAGER_STATUS, this); |
There was a problem hiding this comment.
Not sure if it matters, but I'm always more comfortable setting the boolean after the fact (i.e. inverting those lines). So that it reads "now that I unregistered, I update the boolean that holds the registration state".
Probably just a nitpick though.
There was a problem hiding this comment.
The advantage of that way is that the check and set are right after each other and less likely to drift apart from each other and get lost.
Best case, it should not be a two step approach but one. Actually, we don't need this variable. We can just unregister and if we haven't registered it's silently ignored...
JonasVautherin
approved these changes
Jan 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We should unregister anything we have subscribed to when being destructed.
Related to #2207