-
-
Notifications
You must be signed in to change notification settings - Fork 534
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Distance sensor server #1964
Distance sensor server #1964
Conversation
3f7bbb5
to
dfdc85f
Compare
I'm getting a diff in auto-generated code that is related to this change in Proto that was not accounted for in MAVSDK yet: mavlink/MAVSDK-Proto#306
How should we go about this? I could commit the diff since the changes don't include new logic, just a new enum field for |
Yeah I'd say just commit it, it's not breaking anything, just adding an enum value 👍 |
Caused by this addition to Proto mavlink/MAVSDK-Proto#306 Should be a non-breaking change since it only extends an existing enum.
Good to go from my end. The message is currently quite limited since in MAVSDK-Proto only the most basic fields of DISTANCE_SENSOR are defined. I can extend the message definition at a later point. This is what the current implementation sends out with the example values
|
Related PRs
Description
Implements the publisher for distance sensor measurements. Need to merge Proto changes first.