Add option to build without cURL #1955
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JonasVautherin
previously approved these changes
Jan 11, 2023
Yes, sometimes it's just annoying or difficult to get the dependencies, apparently. I have been asked for this numerous times.
Good point. I don't know where zlib is even required? |
At least Protobuf, I would say. And otherwise I would say curl (for e.g. compressed HTTP responses) 🤔. |
julianoes
force-pushed
the
pr-without-curl-builds
branch
from
a4abbd1 to
543b50e
Compare
julianoes
force-pushed
the
pr-without-curl-builds
branch
from
543b50e to
07195c5
Compare
This adds the cmake configure option BUILD_WITHOUT_CURL which allows building MAVSDK without the cURL dependency. This has been requested numerous times, so it's probably worthwhile adding as an option. For now it means that camera definition files can't be downloaded via http. In the future we will also add the option to download the definition files via MAVLink FTP. Signed-off-by: Julian Oes <julian@oes.ch>
julianoes
force-pushed
the
pr-without-curl-builds
branch
from
07195c5 to
18165e9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the cmake configure option BUILD_WITHOUT_CURL which allows building MAVSDK without the cURL dependency.
This has been requested numerous times, so it's probably worthwhile adding as an option.
For now it means that camera definition files can't be downloaded via http.
In the future we will also add the option to download the definition files via MAVLink FTP.
Closes #830.