Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Local protoc-gen-mavsdk install #1855

Merged
merged 3 commits into from
Jul 14, 2022
Merged

Conversation

julianoes
Copy link
Collaborator

@devbharat suggested to install the protoc-gen-mavsdk package locally and therefore avoiding some of the potential headaches when the system wide package is not the correct version, or not installed.

Objections @JonasVautherin?

devbharat and others added 2 commits July 14, 2022 13:17
Instead of having to install protoc-gen-mavsdk system-wide, this
installs it locally. This way we can make sure to always have the latest
version.
protoc-gen-mavsdk is now installed automatically locally as part of the
generation script.
Copy link
Collaborator

@JonasVautherin JonasVautherin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems alright to me 👍

@julianoes julianoes marked this pull request as ready for review July 14, 2022 19:01
@julianoes julianoes merged commit 48e943b into main Jul 14, 2022
@julianoes julianoes deleted the pr-add-autogen-local-install branch July 14, 2022 19:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants