Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmake: install mavlink headers in correct dir #1819

Merged
merged 1 commit into from
Jun 27, 2022
Merged

Conversation

JonasVautherin
Copy link
Collaborator

@JonasVautherin JonasVautherin commented Jun 27, 2022

Taken from 0c8e236, as it feels useful to merge it ASAP.

Copy link
Contributor

@Katawann Katawann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. With this modification, I succeed to build an example for armv7 target platform

However, I have an error when trying to run the example but not sure if it's related. Maybe is the way I generated the deb package:

error while loading shared libraries: libmavsdk.so.1: cannot open shared object file: No such file or directory

@JonasVautherin
Copy link
Collaborator Author

However, I have an error when trying to run the example but not sure if it's related.

Hmm feels unrelated to me. Maybe worth opening a separate issue for that 👍

@JonasVautherin JonasVautherin merged commit a3c0a5c into main Jun 27, 2022
@JonasVautherin JonasVautherin deleted the fix-mavlink-build branch June 27, 2022 21:52
@julianoes
Copy link
Collaborator

Thanks for fixing this. Do we need another patch release for it?

@Katawann
Copy link
Contributor

I work with a deb package build locally on my side it's all good, but if others try to work with the deb provided on github it won't work

@Katawann
Copy link
Contributor

Katawann commented Oct 5, 2022

@julianoes Would it be possible to do a patch release ? Or do you have a plan to integrate this correction in v1.5.0 and when could we except to be released ?

@julianoes
Copy link
Collaborator

Thanks for the note @Katawann. Here comes a patch for v1.4: #1911.

@julianoes
Copy link
Collaborator

I have the feeling this probably is not required for v1.4. It seems to be broken in v1.4.7. I'll revert it.

The changes in main will eventually be released as v2.

@Katawann
Copy link
Contributor

Arf too bad. I'll wait for new release to test the installation then. Thank you for your help anyway !

@JonasVautherin
Copy link
Collaborator Author

But it works in main, doesn't it?

@Katawann
Copy link
Contributor

I need to test again because I need to build the package to include it in my docker. I come back to you when I found some time to test it

@JonasVautherin
Copy link
Collaborator Author

Got it! Let us know if you find a patch, would be helpful 😊

@Katawann
Copy link
Contributor

I just build debian package with main branch but it still fail with the same error:

/usr/include/mavsdk/plugins/mavlink_passthrough/mavlink_include.h:3:10: fatal error: mavlink/v2.0/common/mavlink.h: No such file or directory
#include "mavlink/v2.0/common/mavlink.h"

Now let's found a fix which does not break installation for others...

@julianoes
Copy link
Collaborator

Ok, so takeaway: main is broken, release should (again be fine) as it was.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants