-
-
Notifications
You must be signed in to change notification settings - Fork 534
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cmake: install mavlink headers in correct dir #1819
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. With this modification, I succeed to build an example for armv7 target platform
However, I have an error when trying to run the example but not sure if it's related. Maybe is the way I generated the deb package:
error while loading shared libraries: libmavsdk.so.1: cannot open shared object file: No such file or directory
Hmm feels unrelated to me. Maybe worth opening a separate issue for that 👍 |
Thanks for fixing this. Do we need another patch release for it? |
I work with a deb package build locally on my side it's all good, but if others try to work with the deb provided on github it won't work |
@julianoes Would it be possible to do a patch release ? Or do you have a plan to integrate this correction in v1.5.0 and when could we except to be released ? |
I have the feeling this probably is not required for v1.4. It seems to be broken in v1.4.7. I'll revert it. The changes in |
Arf too bad. I'll wait for new release to test the installation then. Thank you for your help anyway ! |
But it works in |
I need to test again because I need to build the package to include it in my docker. I come back to you when I found some time to test it |
Got it! Let us know if you find a patch, would be helpful 😊 |
I just build debian package with
Now let's found a fix which does not break installation for others... |
Ok, so takeaway: main is broken, release should (again be fine) as it was. |
Taken from 0c8e236, as it feels useful to merge it ASAP.