params: fix double promise call #1788
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes a segfault/abort when using get_all_params(). The issue was that the timeout handler was not removed as it should have been, and so after a successful completion, we got another call from the timeout handler which then satisfies the promise a second time which is not possible. This did not show up in the integration test (or at least not often) because the test was already destructed by the time the timeout would trigger.
JonasVautherin
previously approved these changes
May 23, 2022
I had introduced unlock calls before calling callbacks in order to prevent deadlocks. I don't think this is required anymore, as all callbacks back to the user are now served later from a queue. This does assume that we don't have any such deadlocks internally though.
JonasVautherin
previously approved these changes
May 23, 2022
The problem is that the function called when a timeout happens, always calls the _all_params_callback which it should not. In fact, there should be two different timeout handlers instead.
JonasVautherin
approved these changes
May 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a segfault/abort when using get_all_params(). The issue was that the timeout handler was not removed as it should have been, and so after a successful completion, we got another call from the timeout handler which then satisfies the promise a second time which is not possible.
This did not show up in the integration test (or at least not often) because the test was already destructed by the time the timeout would trigger.
Fixes #1785.