Fix FTP test segfault #1777
Merged
Fix FTP test segfault #1777
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 3d03fb0.
This makes sure we notify the user when a system actually connects after it has been created in anticipation that it will eventually exist.
JonasVautherin
approved these changes
May 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@JonasVautherin I think the fix you suggested in #1774 does not work in general.
Removing a system is not really supported, so in the case of the FTP test, the ftp plugin is already created from the fake plugin and removing it has bad effects, in this case a segfault.
This PR reverts your commit and adds a commit which instead triggers a discovery notification when a fake system changes to a real system.
However, in the future, given the server components - I think - we can remove the fake system completely. However, this requires us to split the FTP plugin into client and server. That's something I wanted to do but haven't gotten to yet.