core: use separate mavlink_status_t again #1740
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, we made an attempt to fix the outgoing sequence numbers. Therefore, we would ignore the chan number for the mavlink_status_t, however, this lead to serious problems when doing system tests with multiple mavsdk instances sending messages to each other as they would sometimes both use the mavlink_status_t data and mess up each others parsing. Therefore, we remove the previous hack, and go back to separate mavlink_status_t. This will probably mess up outgoing sequence numbers but given they can't reliably be used to assess drop rate anyway it's an ok pill to swallow, for now. And this enables more consistent system tests, and in general applications with more than one Mavsdk instance.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, we made an attempt to fix the outgoing sequence numbers. Therefore, we would ignore the chan number for the mavlink_status_t, however, this lead to serious problems when doing system tests with multiple mavsdk instances sending messages to each other as they would sometimes both use the mavlink_status_t data and mess up each others parsing.
Therefore, we remove the previous hack, and go back to separate mavlink_status_t. This will probably mess up outgoing sequence numbers but given they can't reliably be used to assess drop rate anyway it's an ok pill to swallow, for now. And this enables more consistent system tests, and in general applications with more than one Mavsdk instance.