Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

core: fix uninitialized command #1731

Merged
merged 1 commit into from
Apr 7, 2022
Merged

core: fix uninitialized command #1731

merged 1 commit into from
Apr 7, 2022

Conversation

julianoes
Copy link
Collaborator

Fixes #1729.

@julianoes julianoes added the bug label Apr 7, 2022
@julianoes julianoes requested a review from JonasVautherin April 7, 2022 02:55
JonasVautherin
JonasVautherin approved these changes Apr 7, 2022
View reviewed changes
Copy link
Collaborator

@JonasVautherin JonasVautherin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch

@JonasVautherin JonasVautherin merged commit 656d0c3 into main Apr 7, 2022
@JonasVautherin JonasVautherin deleted the pr-fix-uninit branch April 7, 2022 10:10
@julianoes
Copy link
Collaborator Author

@JonasVautherin credits to @PeterQFR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JonasVautherin JonasVautherin JonasVautherin approved these changes

Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

std::optional for CommandLong always returns true. Causes fault on Ardupilot
2 participants
@julianoes @JonasVautherin