Added altitude to telemetry plugin #300
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JonasVautherin
approved these changes
Oct 28, 2022
protos/telemetry/telemetry.proto
Outdated
Comment on lines
304
to
305
| message SubscribeAltitudeRequest{} | ||
| message AltitudeResponse{ |
There was a problem hiding this comment.
Suggested change
| message SubscribeAltitudeRequest{} | |
| message AltitudeResponse{ | |
| message SubscribeAltitudeRequest {} | |
| message AltitudeResponse { |
protos/telemetry/telemetry.proto
Outdated
| @@ -803,6 +821,16 @@ message GpsGlobalOrigin { | |||
| float altitude_m = 3 [(mavsdk.options.default_value)="NaN"]; // Altitude AMSL (above mean sea level) in metres | |||
| } | |||
|
|
|||
| // Altitude message type | |||
| // For more info see: https://mavlink.io/en/messages/common.html#ALTITUDE | |||
There was a problem hiding this comment.
We try not to leak MAVLink (too much) in the MAVSDK interface 😇.
Suggested change
| // For more info see: https://mavlink.io/en/messages/common.html#ALTITUDE |
JonasVautherin
requested changes
Oct 28, 2022
Removed mavlink message ref link
|
Done the requested changes. Also updated proto module in MAVSDK. 😃 |
JonasVautherin
approved these changes
Oct 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request would close #1903.