Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop Rails 3.x support #9

Merged
merged 17 commits into from
Sep 3, 2019
Merged

Drop Rails 3.x support #9

merged 17 commits into from
Sep 3, 2019

Conversation

shirish-pampoorickal
Copy link
Member

@shirish-pampoorickal shirish-pampoorickal commented Aug 22, 2019

This PR introduces the following changes:

  • Drop support for Ruby versions < 2.2.0
  • Default to Ruby version 2.4.7
  • Drop support for ActiveRecord versions < 4.2
  • Add support for ActiveRecord versions 5.0, 5.1 & 5.2
  • Upgrade Rspec & convert specs to use expect syntax
  • Addressed following deprecations for version > Rails 5.1 while maintaining backward compatibility:
    • The behavior of 'attribute_changed?' inside of after callbacks will be changing in the next version of Rails. The new return value will reflect the behavior of calling the method after 'save' returned (e.g. the opposite of what it returns now). To maintain the current behavior, use 'saved_change_to_attribute?' instead.
    • The behavior of 'attribute_was' inside of after callbacks will be changing in the next version of Rails. The new return value will reflect the behavior of calling the method after 'save' returned (e.g. the opposite of what it returns now). To maintain the current behavior, use 'attribute_before_last_save' instead.

Bigmaven PR: https://github.com/mavenlink/mavenlink/pull/17371

TODO:

  • Bump version

shirish-pampoorickal and others added 7 commits August 22, 2019 17:32
Co-authored-by: Andrew Bates <abates@mavenlink.com>
Co-authored-by: Alan Wong <alan@mavenlink.com>
…e method accessors

Co-authored-by: Andrew Bates <abates@mavenlink.com>
Co-authored-by: Alan Wong <alan@mavenlink.com>
Co-authored-by: Andrew Bates <abates@mavenlink.com>
Co-authored-by: Alan Wong <alan@mavenlink.com>
Copy link

@plainprogrammer plainprogrammer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@plainprogrammer plainprogrammer added lgtm and removed reviewable Ready for Review labels Aug 27, 2019
shirish-pampoorickal and others added 2 commits August 30, 2019 11:41
Co-authored-by: Andrew Bates <abates@mavenlink.com>
Co-authored-by: Alan Wong <alan@mavenlink.com>
Co-authored-by: Andrew Bates <abates@mavenlink.com>
Co-authored-by: Alan Wong <alan@mavenlink.com>
@a-bates a-bates merged commit 8151990 into master Sep 3, 2019
@a-bates a-bates deleted the drop_rails_3_x_support branch September 3, 2019 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

4 participants