-
-
Notifications
You must be signed in to change notification settings - Fork 176
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added support for WhatsApp status replies #661
Added support for WhatsApp status replies #661
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The bridge already has an option for cross-room replies, most clients and servers just don't support that
I think it'd make more sense to just have a link to the original message at the beginning of the reply if the reply target is in another chat and cross-room replies are disabled. Basically changing SetReply
to prepend a blockquote containing some text and a matrix.to event link when the reply points at a different room
portal.go
Outdated
return "text" | ||
case waMsg.ExtendedTextMessage != nil: | ||
return "post_reply" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ExtendedTextMessage
is just a text message with additional metadata, not a status reply specifically. Any text message that includes a reply, a link preview, mentions, or is a disappearing message, will be an extended text message
Hi Tulir, have you had a chance to take a look at the changes we are proposing for this feature?, do you have any suggestions?. We are very interested in making this work. |
Improvement in status reply code and format style
Hi Tulir, I made the adjustments that you suggested, do you have any comments about this? |
I'd love to get this feature implemented? Anything holding it back? |
In order to receive the quoted message of a status reply, a second message is sent to the room to be able to see the content of the status the user replied to.