Added notificationsEnabled config (Closes #242) #269
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Clarified `startForeground` and its notifications
danielgindi
force-pushed
the
feature/notificationsEnabled
branch
from
b16b7de
to
8cf944e
Compare
|
I clarified the docs after updating the related PR |
|
Merged. Thank you! |
mauron85
pushed a commit
that referenced
this pull request
Aug 23, 2018
Clarified `startForeground` and its notifications
mauron85
added a commit
to mauron85/cordova-plugin-background-geolocation
that referenced
this pull request
Aug 23, 2018
Origin-PR: mauron85/react-native-background-geolocation#269 Contributed-By: @danielgindi
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not everyone wants the library to force those notifications on them. There are other ways to convey to the user that the app is tracking in the background.
I have kept the original default where notifications are enabled, and it's an opt-out feature.
Set
notificationsEnabled: falseto disable local notifications.Depends on:
mauron85/background-geolocation-android#10
Also closes:
#242