patch type

matusstafura · Apr 25, 2022 · d048008 · d048008
1 parent 90b0512
commit d048008
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 6 deletions.
diff --git a/src/FioReport.php b/src/FioReport.php
@@ -13,7 +13,7 @@ public function __construct(protected FioApiService $fioApiService)
     {
     }
 
-    public function getReport(string $date_from, string $date_to): mixed
+    public function getReport(string $date_from, string $date_to): array
     {
         try {
             $date_from = Carbon::parse($date_from)->format('Y-m-d');
@@ -33,17 +33,17 @@ public function getReport(string $date_from, string $date_to): mixed
         }
     }
 
-    public function betweenDates(string $date_from, string $date_to): string
+    public function betweenDates(string $date_from, string $date_to): array
     {
         return $this->getReport($date_from, $date_to);
     }
 
-    public function today(): string
+    public function today(): array
     {
         return $this->getReport($this->todayDate(), $this->todayDate());
     }
 
-    public function yesterday(): string
+    public function yesterday(): array
     {
         return $this->getReport($this->yesterdayDate(), $this->yesterdayDate());
     }

diff --git a/tests/Unit/FioReportTest.php b/tests/Unit/FioReportTest.php
@@ -37,9 +37,9 @@
     $fioReport = $this->createMock(\Matusstafura\FioApi\FioReport::class);
     $fioReport->method('getReport')
         ->with("2022-03-11", "2022-03-11")
-        ->willReturn('{"accountStatement":{"info":{"accountId":"123457890","bankId":"4444","currency":"EUR","iban":"SK0000000000000000000000","bic":"FIOZSKBAXXX","openingBalance":10000000.39,"closingBalance":20000000.89,"dateStart":"2022-03-11+0100","dateEnd":"2022-03-11+0100","yearList":null,"idList":null,"idFrom":11111111111,"idTo":22222222222,"idLastDownload":null},"transactionList":{"transaction":[{"column22":{"value":24066596722,"name":"ID pohybu","id":22},"column0":{"value":"2022-03-11+0100","name":"Datum","id":0},"column1":{"value":-25.00,"name":"Objem","id":1},"column14":{"value":"EUR","name":"Měna","id":14},"column2":{"value":"SK5555555555555555555555","name":"Protiúčet","id":2},"column10":{"value":"","name":"Název protiúčtu","id":10},"column3":null,"column12":null,"column4":{"value":"0308","name":"KS","id":4},"column5":{"value":"99999999","name":"VS","id":5},"column6":{"value":"1200000000","name":"SS","id":6},"column7":{"value":" ","name":"Uživatelská identifikace","id":7},"column16":{"value":"Some message","name":"Zpráva pro příjemce","id":16},"column8":{"value":"Bezhotovostní platba","name":"Typ","id":8},"column9":{"value":"Tom Smith","name":"Provedl","id":9},"column18":null,"column25":{"value":"Comment about payment","name":"Komentář","id":25},"column26":{"value":"XXXXSKBXXXX","name":"BIC","id":26},"column17":{"value":88888888888,"name":"ID pokynu","id":17},"column27":null}]}}}');
+        ->willReturn(["accountStatement"=>["info"=>["accountId"=>"123457890","bankId"=>"4444","currency"=>"EUR","iban"=>"SK0000000000000000000000","bic"=>"FIOZSKBAXXX","openingBalance"=>10000000.39,"closingBalance"=>20000000.89,"dateStart"=>"2022-03-11+0100","dateEnd"=>"2022-03-11+0100","yearList"=>null,"idList"=>null,"idFrom"=>11111111111,"idTo"=>22222222222,"idLastDownload"=>null],"transactionList"=>["transaction"=>[["column22"=>["value"=>24066596722,"name"=>"ID pohybu","id"=>22],"column0"=>["value"=>"2022-03-11+0100","name"=>"Datum","id"=>0],"column1"=>["value"=>-25.00,"name"=>"Objem","id"=>1],"column14"=>["value"=>"EUR","name"=>"Měna","id"=>14],"column2"=>["value"=>"SK5555555555555555555555","name"=>"Protiúčet","id"=>2],"column10"=>["value"=>"","name"=>"Název protiúčtu","id"=>10],"column3"=>null,"column12"=>null,"column4"=>["value"=>"0308","name"=>"KS","id"=>4],"column5"=>["value"=>"99999999","name"=>"VS","id"=>5],"column6"=>["value"=>"1200000000","name"=>"SS","id"=>6],"column7"=>["value"=>" ","name"=>"Uživatelská identifikace","id"=>7],"column16"=>["value"=>"Some message","name"=>"Zpráva pro příjemce","id"=>16],"column8"=>["value"=>"Bezhotovostní platba","name"=>"Typ","id"=>8],"column9"=>["value"=>"Tom Smith","name"=>"Provedl","id"=>9],"column18"=>null,"column25"=>["value"=>"Comment about payment","name"=>"Komentář","id"=>25],"column26"=>["value"=>"XXXXSKBXXXX","name"=>"BIC","id"=>26],"column17"=>["value"=>88888888888,"name"=>"ID pokynu","id"=>17],"column27"=>null]]]]]);
 
-    $report = json_decode($fioReport->getReport("2022-03-11", "2022-03-11"), true);
+    $report = $fioReport->getReport("2022-03-11", "2022-03-11");
 
     expect($report['accountStatement']['info'])->toMatchArray([
         'accountId' => '123457890',