Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(azureai): Add support for azure open Ai #377

Merged
merged 7 commits into from
Jan 20, 2025

Conversation

Phiph
Copy link
Contributor

@Phiph Phiph commented Jan 17, 2025

Hey @mattzcarey,

Thanks so much for updating the packages over the last few months, this made adding in the Azure Open AI support much easier - and I feel more confident that it'll work for both OpenAI and Azure Open AI.

I did try to run test:llm however, the memory vector store will need to be changed to use a type that is supported by Azure AI. I'd love to get your thoughts!

I've expanded the check for the env vars, and would happily take any feedback on the outputted message.

Here's a PR showing it working: https://github.com/Phiph/code-review-gpt/pull/2

Copy link
Owner

@mattzcarey mattzcarey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@mattzcarey mattzcarey merged commit 989c26a into mattzcarey:main Jan 20, 2025
1 check passed
@mattzcarey
Copy link
Owner

will release this at the end of the week as 0.6.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants