Remove context row header items

mattrunyon · Jun 7, 2024 · 42c9387 · 42c9387
1 parent 8854c27
commit 42c9387
Show file tree

Hide file tree

Showing 5 changed files with 2 additions and 52 deletions.
diff --git a/plugins/ui/src/deephaven/ui/components/table.py b/plugins/ui/src/deephaven/ui/components/table.py
@@ -26,7 +26,6 @@ def table(
     show_search: bool = False,
     context_items: list[ContextMenuItem] | None = None,
     context_column_header_items: list[ContextMenuItem] | None = None,
-    context_row_header_items: list[ContextMenuItem] | None = None,
 ) -> UITable:
     """
     Customization to how a table is displayed, how it behaves, and listen to UI events.
@@ -54,7 +53,6 @@ def table(
         show_search: Whether to show the search bar by default.
         context_items: The context menu items to show when a cell is right clicked. May contain action items or submenu items.
         context_column_header_items: The context menu items to show when a column header is right clicked. May contain action items or submenu items.
-        context_row_header_items: The context menu items to show when a row header is right clicked. May contain action items or submenu items.
     """
     props = locals()
     del props["table"]

diff --git a/plugins/ui/src/deephaven/ui/elements/UITable.py b/plugins/ui/src/deephaven/ui/elements/UITable.py
@@ -18,12 +18,8 @@
     AggregationOperation,
     QuickFilterExpression,
     Color,
-    ContextMenuAction,
-    CellIndex,
     CellPressCallback,
     ColumnPressCallback,
-    RowData,
-    ContextMenuMode,
     DataBarAxis,
     DataBarValuePlacement,
     DataBarDirection,
@@ -307,42 +303,6 @@ def color_row(
         """
         raise NotImplementedError()
 
-    def context_menu(
-        self,
-        items: (
-            ContextMenuAction
-            | list[ContextMenuAction]
-            | Callable[
-                [CellIndex, RowData], ContextMenuAction | list[ContextMenuAction]
-            ]
-        ),
-        mode: ContextMenuMode = "CELL",
-    ) -> "UITable":
-        """
-        Add custom items to the context menu.
-        You can provide a list of actions that always appear,
-        or a callback that can process the selection and send back menu items asynchronously.
-        You can also specify whether you want the menu items provided for a cell context menu,
-        a header context menu, or some combination of those.
-        You can also chain multiple sets of menu items by calling `.context_menu` multiple times.
-
-        Args:
-            items: The items to add to the context menu.
-                May be a single `ContextMenuAction`, a list of `ContextMenuAction` objects,
-                or a callback function that takes the cell index and row data and returns either a single
-                `ContextMenuAction` or a list of `ContextMenuAction` objects.
-            mode: Which specific context menu(s) to add the menu item(s) to.
-                Can be one or more modes.
-                Using `None` will add menu items in all cases.
-                `CELL`: Triggered from a cell.
-                `ROW_HEADER`: Triggered from a row header.
-                `COLUMN_HEADER`: Triggered from a column header.
-
-        Returns:
-            A new UITable
-        """
-        raise NotImplementedError()
-
     def data_bar(
         self,
         col: str,

diff --git a/plugins/ui/src/js/src/elements/UITable.tsx b/plugins/ui/src/js/src/elements/UITable.tsx
@@ -42,7 +42,6 @@ function UITable({
   showQuickFilters,
   contextItems,
   contextColumnHeaderItems,
-  contextRowHeaderItems,
 }: UITableProps): JSX.Element | null {
   const dh = useApi();
   const irisGridRef = useRef<IrisGridType>(null);
@@ -127,8 +126,7 @@ function UITable({
               irisGrid,
               model,
               contextItems,
-              contextColumnHeaderItems,
-              contextRowHeaderItems
+              contextColumnHeaderItems
             ),
           ] as readonly GridMouseHandler[])
         : undefined,
@@ -144,7 +142,6 @@ function UITable({
       onRowDoublePress,
       contextItems,
       contextColumnHeaderItems,
-      contextRowHeaderItems,
     ]
   );
 

diff --git a/plugins/ui/src/js/src/elements/UITableContextMenuHandler.ts b/plugins/ui/src/js/src/elements/UITableContextMenuHandler.ts
@@ -22,22 +22,18 @@ class UITableContextMenuHandler extends IrisGridContextMenuHandler {
 
   private contextColumnHeaderItems: UITableProps['contextColumnHeaderItems'];
 
-  private contextRowHeaderItems: UITableProps['contextRowHeaderItems'];
-
   constructor(
     dh: typeof DhType,
     irisGrid: IrisGridType,
     model: IrisGridModel,
     contextMenuItems: UITableProps['contextItems'],
-    contextColumnHeaderItems: UITableProps['contextColumnHeaderItems'],
-    contextRowHeaderItems: UITableProps['contextRowHeaderItems']
+    contextColumnHeaderItems: UITableProps['contextColumnHeaderItems']
   ) {
     super(irisGrid, dh);
     this.irisGrid = irisGrid;
     this.model = model;
     this.contextMenuItems = contextMenuItems;
     this.contextColumnHeaderItems = contextColumnHeaderItems;
-    this.contextRowHeaderItems = contextRowHeaderItems;
   }
 
   getHeaderActions(

diff --git a/plugins/ui/src/js/src/elements/UITableUtils.tsx b/plugins/ui/src/js/src/elements/UITableUtils.tsx
@@ -53,7 +53,6 @@ export interface UITableProps {
   showQuickFilters: boolean;
   contextItems?: UIContextItem[];
   contextColumnHeaderItems?: UIContextItem[];
-  contextRowHeaderItems?: UIContextItem[];
   [key: string]: unknown;
 }