forked from gnome-terminator/terminator
-
Notifications
You must be signed in to change notification settings - Fork 0
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
add parameters to remotinator split commands
- Loading branch information
Showing
2 changed files
with
22 additions
and
6 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
97c582c
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ooo, very nice, I like this much better than having separate
vsplit_cmd
andhsplit_cmd
, we should probably just remove those as separate dbus commands since this implements the same functionality directly intovsplit
andhsplit
as an option. Much simpler! Since you haven't cut a release withvsplit_cmd
andhsplit_cmd
in it yet, those functions are safe to remove now before you release the next version.97c582c
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, I was going to ask you if I could repurpose yours, but I decided to just add parameters to vsplit and hsplit instead. I'll remove vsplit_cmd and hsplit_cmd.