Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update "database is locked" documentation #827

Closed
wants to merge 1 commit into from
Closed

Update "database is locked" documentation #827

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 12 additions & 6 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -526,17 +526,23 @@ For an example see [dinedal/go-sqlite3-extension-functions](https://github.com/d

- Error: `database is locked`

When you get a database is locked. Please use the following options.
This means two different connections are trying to write to the database at
the same time.

Add to DSN: `cache=shared`
One way to fix this is to ensure your program limits the number of writers
to 1, for example by using `sync.Mutex` (it's fine to be have multiple
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Having multiple writers is actually not itself a problem. However, what can cause an issue even with write-ahead logging is if a connection tries to write after reading within a transaction.

tx := database.Begin()
...
tx.QueryRow(`SELECT ID FROM Foo WHERE ...`)
...
tx.Exec(`UPDATE Foo ...`)
...

The problem here is that if the database gets modified between the SELECT and the UPDATE by another connection, there is no way for SQLite to properly retain the "isolation" property of ACID. This is because the interim modification may have changed the very data you read out. This issue can be avoided by always using immediate locking behavior (i.e., BEGIN IMMEDIATE) for any transactions that may ultimately write to the database. (It of course is also avoided by throttling the connection pool to one, provided that no other applications will also be writing to the same database.)

reads, even when writing).

Adding `_journal_mode=wal` improves the general concurrency in most cases,
although it doesn't 100% eliminate locking issues:

Example:
```go
db, err := sql.Open("sqlite3", "file:locked.sqlite?cache=shared")
db, err := sql.Open("sqlite3", "file:locked.sqlite?_journal_mode=wal")
```

Second please set the database connections of the SQL package to 1.

To guarantee only one connection is being run at the same time yoi can set
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
To guarantee only one connection is being run at the same time yoi can set
To guarantee only one connection is being run at the same time, you can set

the maximum number of database connections to `1`:

```go
db.SetMaxOpenConns(1)
```
Expand Down