Skip to content

Add -image-alt flag to post alt text #8

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 5, 2023

Conversation

backspace
Copy link
Contributor

Hey, I came here because I noticed that bskybots uses your library for the meme bot but the alt text is just a filename. Here’s a prototype that adds an -image-alt flag to override the filename. You can see it successfully worked here.

There’s at least one problem I’m aware of, if you ran something like this:

bsky post -image i1.png -image-alt "image description 1" -image i2.png -image i3.png -image-alt "image description 3" "some images"

This implementation would miss the alt text for the third image. I looked at the urfave/cli documentation and couldn’t find anything about pairing flags but I’m barely familiar with Go and could have missed something.

Thanks for all the work on this! 🤩

@mattn mattn merged commit 7a7ca3b into mattn:main May 5, 2023
@mattn
Copy link
Owner

mattn commented May 5, 2023

Thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants