Merge pull request microsoft#27688 from Microsoft/fixTsBuildIncrement…

…alNoErrorScenario Remove any existing errors in case of successful build in tsbuild watch mode
mattmccutchen · Oct 10, 2018 · 3e91652 · 3e91652
2 parents dd764b3 + ba0f558
commit 3e91652
Show file tree

Hide file tree

Showing 2 changed files with 55 additions and 0 deletions.
diff --git a/src/compiler/tsbuild.ts b/src/compiler/tsbuild.ts
@@ -1066,6 +1066,9 @@ namespace ts {
                 type: UpToDateStatusType.UpToDate,
                 newestDeclarationFileContentChangedTime: anyDtsChanged ? maximumDate : newestDeclarationFileContentChangedTime
             };
+            if (options.watch) {
+                diagnostics.removeKey(proj);
+            }
             projectStatus.setValue(proj, status);
             return resultFlags;
 

diff --git a/src/testRunner/unittests/tsbuildWatchMode.ts b/src/testRunner/unittests/tsbuildWatchMode.ts
@@ -356,6 +356,58 @@ function myFunc() { return 100; }`);
             }
         });
 
+        it("when referenced project change introduces error in the down stream project and then fixes it", () => {
+            const subProjectLibrary = `${projectsLocation}/${project}/Library`;
+            const libraryTs: File = {
+                path: `${subProjectLibrary}/library.ts`,
+                content: `
+interface SomeObject
+{
+	message: string;
+}
+
+export function createSomeObject(): SomeObject
+{
+	return {
+		message: "new Object"
+	};
+}`
+            };
+            const libraryTsconfig: File = {
+                path: `${subProjectLibrary}/tsconfig.json`,
+                content: JSON.stringify({ compilerOptions: { composite: true } })
+            };
+            const subProjectApp = `${projectsLocation}/${project}/App`;
+            const appTs: File = {
+                path: `${subProjectApp}/app.ts`,
+                content: `import { createSomeObject } from "../Library/library";
+createSomeObject().message;`
+            };
+            const appTsconfig: File = {
+                path: `${subProjectApp}/tsconfig.json`,
+                content: JSON.stringify({ references: [{ path: "../Library" }] })
+            };
+
+            const files = [libFile, libraryTs, libraryTsconfig, appTs, appTsconfig];
+            const host = createWatchedSystem(files, { currentDirectory: `${projectsLocation}/${project}` });
+            createSolutionBuilderWithWatch(host, ["App"]);
+            checkOutputErrorsInitial(host, emptyArray);
+
+            // Change message in library to message2
+            host.writeFile(libraryTs.path, libraryTs.content.replace(/message/g, "message2"));
+            host.checkTimeoutQueueLengthAndRun(1); // Build library
+            host.checkTimeoutQueueLengthAndRun(1); // Build App
+            checkOutputErrorsIncremental(host, [
+                "App/app.ts(2,20): error TS2551: Property 'message' does not exist on type 'SomeObject'. Did you mean 'message2'?\n"
+            ]);
+
+            // Revert library changes
+            host.writeFile(libraryTs.path, libraryTs.content);
+            host.checkTimeoutQueueLengthAndRun(1); // Build library
+            host.checkTimeoutQueueLengthAndRun(1); // Build App
+            checkOutputErrorsIncremental(host, emptyArray);
+        });
+
         describe("reports errors in all projects on incremental compile", () => {
             function verifyIncrementalErrors(defaultBuildOptions?: BuildOptions, disabledConsoleClear?: boolean) {
                 const host = createSolutionInWatchMode(allFiles, defaultBuildOptions, disabledConsoleClear);