Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Svelte 5 #36

Merged
merged 29 commits into from
Nov 3, 2024
Merged

Svelte 5 #36

merged 29 commits into from
Nov 3, 2024

Conversation

mattjennings
Copy link
Owner

@mattjennings mattjennings commented Oct 25, 2024

Fixes

As of Svelte 5, events are handled by passing callback props. Added documentation.

Supported in Svelte 5 by using Snippets. Added documentation.

openModal is now modals.open and returns a promise that is resolved when the modal is closed. The modal component can return a value to the promise with its close() prop

Other

fixed

Copy link

vercel bot commented Oct 25, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
svelte-modals ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 3, 2024 2:32am

@mattjennings mattjennings changed the base branch from main to next November 3, 2024 02:31
@mattjennings mattjennings changed the title v2.0.0 Svelte 5 Nov 3, 2024
@mattjennings mattjennings marked this pull request as ready for review November 3, 2024 02:33
@mattjennings mattjennings merged commit 9186c5e into next Nov 3, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant