Skip to content

Commit

Permalink
Add PauseOnStart Recording Option (Azure#39132)
Browse files Browse the repository at this point in the history
* generated files using swagger

* removed extra swagger file

* modified unit tests

* undo status code change for mute participant in generated files

* merged with main

* merged with main

* reverted 202 change

* Both status code changed to 202

* modified test cases to check for 200 status code

* regenerated code

* regenerated code

* Revert "regenerated code"

This reverts commit a5a9e0e.

* Added TransciptionDataRequest Change

* generated from latest swagger

* generated netstandard2.0.cs

* edited changelog

* Revert "generated netstandard2.0.cs"

This reverts commit 2a39b2d.

* Revert "edited changelog"

This reverts commit 7eb1425.

* added line to changelog and standard2.0.cs

* Update CHANGELOG.md
  • Loading branch information
amariwest-msft authored and matthohn-msft committed Oct 27, 2023
1 parent fb3dd91 commit d43ccfe
Show file tree
Hide file tree
Showing 6 changed files with 13 additions and 1 deletion.
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
## 1.1.0-beta.1 (Unreleased)

### Features Added
- StartRecording now accepts PauseOnStart.

### Breaking Changes

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -1317,6 +1317,7 @@ public StartRecordingOptions(Azure.Communication.CallAutomation.CallLocator call
public System.Collections.Generic.IList<Azure.Communication.CommunicationIdentifier> AudioChannelParticipantOrdering { get { throw null; } }
public System.Collections.Generic.IList<Azure.Communication.CallAutomation.ChannelAffinity> ChannelAffinity { get { throw null; } set { } }
public Azure.Communication.CallAutomation.ExternalStorage ExternalStorage { get { throw null; } set { } }
public bool PauseOnStart { get { throw null; } set { } }
public Azure.Communication.CallAutomation.RecordingChannel RecordingChannel { get { throw null; } set { } }
public Azure.Communication.CallAutomation.RecordingContent RecordingContent { get { throw null; } set { } }
public Azure.Communication.CallAutomation.RecordingFormat RecordingFormat { get { throw null; } set { } }
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -62,6 +62,7 @@ public virtual Response<RecordingStateResult> Start(StartRecordingOptions option
RecordingChannelType = options.RecordingChannel,
RecordingContentType = options.RecordingContent,
RecordingFormatType = options.RecordingFormat,
PauseOnStart = options.PauseOnStart,
};

if (options.AudioChannelParticipantOrdering != null && options.AudioChannelParticipantOrdering.Any())
Expand Down Expand Up @@ -119,6 +120,7 @@ public virtual async Task<Response<RecordingStateResult>> StartAsync(StartRecord
RecordingChannelType = options.RecordingChannel,
RecordingContentType = options.RecordingContent,
RecordingFormatType = options.RecordingFormat,
PauseOnStart = options.PauseOnStart,
};

if (options.AudioChannelParticipantOrdering != null && options.AudioChannelParticipantOrdering.Any())
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -45,6 +45,11 @@ public StartRecordingOptions(CallLocator callLocator)
/// </summary>
public RecordingFormat RecordingFormat { get; set; }

/// <summary>
/// The pause on start option.
/// </summary>
public bool PauseOnStart { get; set; }

/// <summary>
/// The sequential order in which audio channels are assigned to participants in the unmixed recording.
/// When 'recordingChannelType' is set to 'unmixed' and `audioChannelParticipantOrdering is not specified,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@ tag: package-2023-01-15-preview
require:
- https://github.com/williamzhao87/azure-rest-api-specs/blob/e31fe487ab3f775d659edf3945b9239ac910314a/specification/communication/data-plane/CallAutomation/readme.md


title: Azure Communication Services

generation1-convenience-client: true
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -194,7 +194,8 @@ private CallRecording getMockCallRecording(int statusCode, string? responseConte
RecordingChannel = RecordingChannel.Mixed,
RecordingFormat = RecordingFormat.Mp4,
AudioChannelParticipantOrdering = { new CommunicationUserIdentifier("test") },
ChannelAffinity = testChannelAffinities
ChannelAffinity = testChannelAffinities,
PauseOnStart = false,
})
},
new Func<CallRecording, TestDelegate>?[]
Expand Down Expand Up @@ -236,6 +237,7 @@ private CallRecording getMockCallRecording(int statusCode, string? responseConte
RecordingChannel = RecordingChannel.Mixed,
RecordingFormat = RecordingFormat.Mp4,
ChannelAffinity = testChannelAffinities,
PauseOnStart = false,
AudioChannelParticipantOrdering = { new CommunicationUserIdentifier("test"),}
}).ConfigureAwait(false),
},
Expand Down

0 comments on commit d43ccfe

Please sign in to comment.