Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Symfony 7 support #67

Merged
merged 5 commits into from
May 24, 2024
Merged

Conversation

tarlepp
Copy link
Contributor

@tarlepp tarlepp commented May 1, 2024

I'm not familiar with Behat tests so could someone give some help to solve that issue?

Fixed this Behat issue, just needed to convert some @Assert docblocks to attributes.

Another thing that I found is InteractiveFormContainerAwareCommand which is using Symfony\Component\DependencyInjection\ContainerAwareTrait; and that is deprecated.

Although didn't find any references to this abstract class on code or documentation, should we just remove that trait from that abstract class or what?

Fixed #66

@matthiasnoback
Copy link
Owner

Cool!

Another thing that I found is InteractiveFormContainerAwareCommand which is using Symfony\Component\DependencyInjection\ContainerAwareTrait; and that is deprecated.

Sounds okay to remove this one.

@tarlepp
Copy link
Contributor Author

tarlepp commented May 17, 2024

Cool!

Another thing that I found is InteractiveFormContainerAwareCommand which is using Symfony\Component\DependencyInjection\ContainerAwareTrait; and that is deprecated.

Sounds okay to remove this one.

Or should we marked that as deprecated first and in next major version remove that?

@matthiasnoback
Copy link
Owner

I think we can get rid of it and release the next major version for this package. The documented way (in the README file) is the best way to use this tool I think.

@tarlepp
Copy link
Contributor Author

tarlepp commented May 22, 2024

I think we can get rid of it and release the next major version for this package. The documented way (in the README file) is the best way to use this tool I think.

Roger, will do that later today.

@matthiasnoback matthiasnoback merged commit 233d6c1 into matthiasnoback:master May 24, 2024
4 checks passed
@matthiasnoback
Copy link
Owner

Thanks, released as v6.0.0 https://github.com/matthiasnoback/symfony-console-form/releases/tag/v6.0.0

@tarlepp tarlepp deleted the symfony-7-support branch October 2, 2024 20:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support for Symfony 7
2 participants