Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ruby 2.4 to travis (bump 2.2 and 2.3 versions) #64

Merged
merged 2 commits into from
May 11, 2017

Conversation

jrafanie
Copy link
Contributor

@jrafanie jrafanie commented May 3, 2017

Add ruby 2.4 and bump the 2.2 and 2.3 versions tested in travis

.travis.yml Outdated
@@ -9,6 +9,7 @@ rvm:
- 2.1.10
- 2.2.5
Copy link
Contributor

@pboling pboling May 4, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jrafanie , CC @matthewrudy might as well bump others to latest patches, 2.2.7 and 2.3.4. They are available as binary downloads on travis via RVM so won't affect the build speed.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, I can do that in an additional commit or PR if it's acceptable. I wanted to only add 2.4 in this PR. I'm ok either way. It's easy enough to change the description.

@jrafanie jrafanie changed the title Add ruby 2.4 to travis Add ruby 2.4 to travis (bump 2.2 and 2.3 versions) May 4, 2017
Copy link
Contributor

@pboling pboling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@matthewrudy
Copy link
Owner

Done...
thanks!

@matthewrudy matthewrudy merged commit 72fe626 into matthewrudy:master May 11, 2017
@jrafanie jrafanie deleted the add_ruby_24 branch May 11, 2017 18:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants