Skip to content

Commit

Permalink
add package-lock.json
Browse files Browse the repository at this point in the history
This was intentionally omitted previously, because travis ci would end up with mismatched versions of chrome and chromedriver otherwise
  • Loading branch information
nfriedly committed May 10, 2024
1 parent 548022c commit a6b1053
Show file tree
Hide file tree
Showing 2 changed files with 5,334 additions and 8 deletions.
8 changes: 0 additions & 8 deletions .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -6,14 +6,6 @@
/tests/test-app/.pnp
.pnp.js

# this is to work around travis ci issues:
# travis only allows you to request the current stable or beta versions of chrome, not a specific version
# chromedriver versions are tied to specific chrome versions
# we currently request chrome stable in .travis.yml and the latest stable chromedriver in package.json
# however, if there is a package-lock.json it will specify a particular version of chromedriver and travis-ci will use that
# this then leads to test failures later on when they get out of sync
package-lock.json

# testing
/coverage
/tests_output
Expand Down
Loading

0 comments on commit a6b1053

Please sign in to comment.