Resolve Comments

* Change INVALID_ARGUMENT to FAILED_PRECONDITION * Remove invokemethod constant
matthewd0123 · Jul 26, 2024 · 4dcfb0e · 4dcfb0e
1 parent 71f699f
commit 4dcfb0e
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 3 deletions.
diff --git a/test_agent/java/src/main/java/org/eclipse/uprotocol/Constants/ActionCommands.java b/test_agent/java/src/main/java/org/eclipse/uprotocol/Constants/ActionCommands.java
@@ -25,7 +25,6 @@ public class ActionCommands {
      public static final String SEND_COMMAND = "send";
      public static final String REGISTER_LISTENER_COMMAND = "registerlistener";
      public static final String UNREGISTER_LISTENER_COMMAND = "unregisterlistener";
-     public static final String INVOKE_METHOD_COMMAND = "invokemethod";
      public static final String RESPONSE_ON_RECEIVE = "onreceive";
      public static final String RESPONSE_RPC = "rpcresponse";
      public static final String SERIALIZE_URI = "uri_serialize";

diff --git a/test_agent/java/src/main/java/org/eclipse/uprotocol/TestAgent.java b/test_agent/java/src/main/java/org/eclipse/uprotocol/TestAgent.java
@@ -158,12 +158,12 @@ private static Object handleInitializeTransportCommand(Map<String, Object> jsonD
             if (transportName.equals("socket")) {
                 transport = new SocketUTransport(uri);
             } else {
-                UStatus status = UStatus.newBuilder().setCode(UCode.INVALID_ARGUMENT).setMessage("").build();
+                UStatus status = UStatus.newBuilder().setCode(UCode.FAILED_PRECONDITION).setMessage("").build();
                 sendToTestManager(status, ActionCommands.INITIALIZE_TRANSPORT, testID);
             }
         } catch (IOException e) {
             e.printStackTrace();
-            UStatus status = UStatus.newBuilder().setCode(UCode.INVALID_ARGUMENT).setMessage("").build();
+            UStatus status = UStatus.newBuilder().setCode(UCode.FAILED_PRECONDITION).setMessage("").build();
             sendToTestManager(status, ActionCommands.INITIALIZE_TRANSPORT, testID);
         }
         UStatus status = UStatus.newBuilder().setCode(UCode.OK).setMessage("").build();