Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enforce type annotations. #99

Merged
merged 5 commits into from
Jul 19, 2021
Merged

Conversation

HexDecimal
Copy link
Collaborator

This adds checks for MyPy, and ensures the typing and typing_extensions modules are available. py.typed marks the package as typed.

six wasn't added but it probably should be. Python 2 string typing will be difficult without it.

@matthew-brett
Copy link
Owner

@HexDecimal - anything left here that didn't go in with #94?

Ignore the lack of type-hinting from the wheel package.
This module is auto-generated without type hints, and would be difficult
to annotate.
six.ensure_str was only needed for the Text type which is exclusive to Python 2.
@HexDecimal
Copy link
Collaborator Author

This PR still does a lot of important things, including adding Mypy to a GitHub workflow and marking Delocate as a type-checked package for scripts which import it.

I've just updated it for Python 3.6.

@matthew-brett
Copy link
Owner

Feel free to merge when tests pass.

@HexDecimal
Copy link
Collaborator Author

I'm not a maintainer with merge permissions.

@matthew-brett
Copy link
Owner

Sorry - I forgot. I've sent you an invite.

@HexDecimal HexDecimal merged commit b2479c6 into matthew-brett:master Jul 19, 2021
@HexDecimal HexDecimal deleted the enforce-mypy branch July 19, 2021 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants