Fix OCTT test cases 2 #383
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OCPP-J Message IDs must be unique per "Connection URL", including across
different WebSocket connection instances. Below is the text from the
Test Laboratory Working Instruction describing OCA's position.
The message IDs were intended to at least be unique per defined
'Connection URL' as specified by section 3.1.1 of the OCPP-J
specification (In case of OCPP 1.6) or "Part 4 - JSON over WebSockets
implementation guide" (In case of OCPP 2.0.1). By this it is meant
unique on any WebSocket connection using the same unique Charging
Station identifier. An erratum will be published in the near future for
this. Please notify the vendors about this still upcoming erratum. From
this moment on, no retests will be granted for this issue.
To verify if a Charging Station is behaving correctly, testcases 013,
014, 015, 016, 032, 034 and 044 can be used for checking this after
rebooting, test cases 036, 037_1, 037_2, 037_3, 038 and 039 can be used
for testing the behavior a when reconnection. If an incrementally
increasing message ID is being used by the system, then it should NOT
be reset to 0 or 1 after reconnection / reboot.
To verify if a CSMS is behaving correctly, any testcase can be used
after stopping the test session. Because stopping the test session
will close the connection with the CSMS.
Changes:
* Added a Random Number Generator (RNG) platform API to microOCPP, with
a hashed-time based default implementation.
* Add UUID generation for Message IDs using the RNG API.
Heartbeat messages are dropped from the request queue if they are more than 4 seconds old. This is on recommendation of the OCA to keep the heartbeat interval within 4s of the interval provided by the CSMS. If heartbeat messages are queued for longer than 4s, the resulting interval will exceed this recommendation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up PR of #344
These patches improve the message ID generation and fix some timing issues to pass further OCTT test cases.