Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Type deduction fixed #67

Merged
merged 1 commit into from
Mar 17, 2017

Conversation

offa
Copy link
Collaborator

@offa offa commented Mar 17, 2017

Type deduction fixed (issue #66).

Copy link
Owner

@mattgodbolt mattgodbolt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect: thanks!

@@ -68,7 +68,7 @@ class ResponseBuilder {

template<typename T>
ResponseBuilder& operator << (T&& t) {
(*_stream) << std::forward(t);
(*_stream) << std::forward<T>(t);
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whoops! Thanks! :)


using namespace seasocks;

TEST_CASE("appendIntValue", "[ResponseBuilderTests]") {
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so much for adding the tests that so clearly I needed!

@mattgodbolt mattgodbolt merged commit 6488d1a into mattgodbolt:master Mar 17, 2017
@offa offa deleted the issue66/type_deduction_fix branch March 17, 2017 13:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants