This repository has been archived by the owner on Jun 28, 2018. It is now read-only.
Proposed fix for migration file name clashes #48
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added a unit test to demonstrate the problem in issue #45 The introduced makeFiles() function could be used to simplify the other tests too, but I didn't touch more than necessary for this commit.
This is the bare minimum proposed fix for #45 By using a nested map the way I do in this PR we could also simplify the logic further down where we look for matching direction.Up or direction.Down migrations.
mattes
added a commit
that referenced
this pull request
Sep 15, 2015
Proposed fix for migration file name clashes
|
Thanks! 👍 |
|
Thanks @mattes |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a proposed fix for #45
I added a unit test to demonstrate the issue, and a proposed solution. Both the test and the fix could be leveraged for more refactoring if that's of interest.