[MM-58843] Only accept valid MM ids in URLs #1920
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
remove extra exact spacing remove extra space
JulienTant
added
2: Dev Review
JulienTant
requested review from
lieut-data
and removed request for
calebroseland
lieut-data
approved these changes
Jun 26, 2024
JulienTant
added a commit
that referenced
this pull request
Aug 21, 2024
* only accept valid MM ids remove extra exact spacing remove extra space * tests want valid id * fix loose path * fix my alphabet * remove debug consolelog * strict path on runs route * exact, not strict * add test for invalid url * add test on invalid urls
JulienTant
added a commit
that referenced
this pull request
Aug 21, 2024
* only accept valid MM ids remove extra exact spacing remove extra space * tests want valid id * fix loose path * fix my alphabet * remove debug consolelog * strict path on runs route * exact, not strict * add test for invalid url * add test on invalid urls
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Only accept valid MM ids in URLs
Ticket Link
https://mattermost.atlassian.net/browse/MM-58843