MM-54130 MM-54149 MM-54151 Fix validation #1868
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crspeller
changed the title
sbishel
approved these changes
Aug 24, 2023
calebroseland
approved these changes
Aug 28, 2023
There was a problem hiding this comment.
LGTM, but TestActionList/view_list_allowed appears to be failing and might need updating
=== FAIL: server TestActionList/view_list_allowed (0.01s)
api_actions_test.go:265:
Error Trace: /home/runner/work/mattermost-plugin-playbooks/mattermost-plugin-playbooks/server/api_actions_test.go:265
Error: "[{{w4jxndq8ybgymmabkjio5keubr fyoq95df9infujppc4nxw336ko %!s(bool=true) %!s(int64=0) categorize_channel new_member_joins} map[category_name:category]} {{ubujbi7yqjboi8o3b6gxoz7gya fyoq95df9infujppc4nxw336ko %!s(bool=true) %!s(int64=0) send_welcome_message new_member_joins} map[message:msg]}]" should have 3 item(s), but has 2
Test: TestActionList/view_list_allowed
--- FAIL: TestActionList/view_list_allowed (0.01s)
|
/check-cla |
crspeller
added
4: Reviews Complete
|
/check-cla |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://mattermost.atlassian.net/browse/MM-54130
https://mattermost.atlassian.net/browse/MM-54149
https://mattermost.atlassian.net/browse/MM-54151