restore the missing Plugin telemetry key #1866
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For now, we're just hard-coding this while still honouring the server configuration as to whether or not to emit telemetry in the first place. In the future, we should integrate knowledge of the service environment and use that to key off which key (if any) to use.
crspeller
approved these changes
Aug 17, 2023
|
I'll look into the e2e test issues when we pre-package and run the suite there. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
For now, we're just hard-coding this while still honouring the server configuration as to whether or not to emit telemetry in the first place.
In the future, we should integrate knowledge of the service environment and use that to key off which key (if any) to use.
Ticket Link
None.