Fix bad location for GITLAB_PKI_CHAIN_PATH option #68
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cpanato
approved these changes
Nov 11, 2021
|
Hello @mrckndt please could you have a look and approve the fix for the wrong location on my previous PR as I explained in the description ? 😃 Thank you very much. 🙏 |
|
Hi @hanzei , Do you have any news about this PR ? Thank you very much 🙏 |
|
Hello, is it possible to have any news about my PR ? I opened it 1 months ago 😢 |
hanzei
added
3: Reviews Complete
|
Got approval from @mrckndt offline |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Here is the pull request to fix the issue I open about missing code that I already PR in the previous repository.
This PR is to fix a wrong location commited in #52
I'm using it in Production and the right place is in
docker-compose.ymlnot indocker-compose.nginx.yml@hanzei Please could you ask for a review ?
@metanerd, @cpanato, @mrckndt Please could you have a look into this one ?
Thank you very much and sorry for the mistake
Ticket Link
Fixes #34
Originally posted by @craph in mattermost/mattermost-docker#529 (comment)