Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MM-48557] Fix AppImage shortcut #2413

Merged
merged 1 commit into from
Nov 22, 2022
Merged

[MM-48557] Fix AppImage shortcut #2413

merged 1 commit into from
Nov 22, 2022

Conversation

devinbinnie
Copy link
Member

Summary

Apparently we never fixed the AppImage shortcuts once the fix to electron-builder was merged. The issue with the --no-sandbox flag causing the app to crash is resolved by this fix.

Ticket Link

https://mattermost.atlassian.net/browse/MM-48557

Fixed an issue where the Applmage when added with the AppImageLauncher would not allow the app to launch correctly

@devinbinnie devinbinnie added 2: Dev Review Requires review by a core committer CherryPick/Approved Meant for the quality or patch release tracked in the milestone labels Nov 22, 2022
@devinbinnie devinbinnie added this to the v5.2.0 milestone Nov 22, 2022
m1lt0n
m1lt0n approved these changes Nov 22, 2022
View reviewed changes
Copy link
Contributor

@m1lt0n m1lt0n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎆

tboulis
tboulis approved these changes Nov 22, 2022
View reviewed changes
Copy link
Contributor

@tboulis tboulis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@devinbinnie devinbinnie merged commit 911ae29 into mattermost:master Nov 22, 2022
@mattermod
Copy link
Contributor

Cherry pick is scheduled.

mattermost-build pushed a commit to mattermost-build/desktop that referenced this pull request Nov 22, 2022
@devinbinnie @mattermost-build
[MM-48557] Fix AppImage shortcut (mattermost#2413)
8484620 
(cherry picked from commit 911ae29)
@mattermost-build mattermost-build mentioned this pull request Nov 22, 2022
Merged
@mattermod mattermod added CherryPick/Done Successfully cherry-picked to the quality or patch release tracked in the milestone and removed CherryPick/Approved Meant for the quality or patch release tracked in the milestone labels Nov 22, 2022
devinbinnie added a commit that referenced this pull request Nov 22, 2022
@mattermost-build @devinbinnie
[MM-48557] Fix AppImage shortcut (#2413) (#2414)
142962d 
(cherry picked from commit 911ae29)

Co-authored-by: Devin Binnie <52460000+devinbinnie@users.noreply.github.com>
@devinbinnie devinbinnie mentioned this pull request May 5, 2023
Closed
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@m1lt0n m1lt0n m1lt0n approved these changes

@tboulis tboulis tboulis approved these changes

Assignees
No one assigned
Labels
2: Dev Review Requires review by a core committer CherryPick/Done Successfully cherry-picked to the quality or patch release tracked in the milestone release-note
Projects
None yet
Milestone
v5.2.0
Development

Successfully merging this pull request may close these issues.
5 participants
@devinbinnie @mattermod @m1lt0n @tboulis @mm-cloud-bot