Migrate DM and private group message boards to a team #2557
Conversation
… into sidebar-categories
* Add workspace to teams and boards migrations * Update json annotations on board models
* Optimizing table view * Reducing the amount of rendering for tables * Some other performance improvements * Improve the activeView updates * Some extra simplifications * Another small improvement * Fixing tests * Fixing linter errors * Reducing a bit the amount of dependency with big objects in the store * Small simplification
* Initial work on permissions gates * Applying permissions gates in more places * Adding more checks to the interface * Adding more permissions gates and keeping the store up to date * fixing some tests * Fixing some more tests * Fixing another test * Fixing all tests and adding some more * Adding no-permission snapshot tests * Addressing PR review comments * cleanup some shareboard settings * remove unused property, fix for user items being displayed for non admin * revert change, allow users to show Co-authored-by: Jesús Espino <jespinog@gmail.com> Co-authored-by: Mattermod <mattermod@users.noreply.github.com>
* fix sqlite table lock * remove test db on teardown * revert .gitignore * fix goimport on migration code * fix typo * more linter fixes * clean up tmp db for sqlstore tests Co-authored-by: Mattermod <mattermod@users.noreply.github.com>
* Migrating center panel to functional component * Fixing some tests * Fixing another test * Fixing linter errors * Fixing types errors * Fixing linter error * Fixing cypress tests * Fixing the last cypress test * Simpliying a bit the code * Making property insertion more robust * Updating checkbox test
|
@harshilsharma63 - Can we get this updated before reviewing? |
@sbishel done. The flaky cypress tests are causing the CI to fail, but everything else is working fine. |
| @@ -67,7 +67,6 @@ linters: | |||
| - unconvert | |||
| - unused | |||
| - whitespace | |||
| - gocyclo | |||
There was a problem hiding this comment.
@jespino it was complaining about cyclomatic complexity exceeding the default threshold of 30 for the data migration function (which currently handles about 4-5 kinds of data migrations). IN the future, I see only more data migrations being added there, so increasing the linter's threshold value won't work in the long term.
I can optimize the code to reduce the conditions and returns paths but it won't work for long when we add the next data migration.
Hence, I removed the linter altogether. I'm open to any alternate solution.
|
/update-branch |
Summary
Migrate DM and private group message boards to a team
Ticket Link
Fixes #2398