Fix #2333. Handle export in Mac App #2334
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chenilim
requested review from
wiggin77 and
sbishel
and removed request for
a team
chenilim
added
the
CherryPick/Candidate
sbishel
approved these changes
Feb 14, 2022
|
@chenilim - there is a build failure. |
|
Thanks, the build failure is because the workflows are running an old Xcode version (12.4). I'll submit a PR to update the workflow to use the latest (macOS 11 and Xcode 13.2.1). |
|
@chenilim are you sure you want to delete existing file on collision versus append a number to make unique? |
|
@wiggin77 in the file picker, on clicking Save, a warning message is shown prompting the user to replace the file:
The delete code executes after the user chooses to replace, and I believe this matches the user intent. |
wiggin77
approved these changes
Feb 15, 2022
|
PR to update workflow macOS and Xcode version is #2338. I'll merge this in after that is merged. |
chenilim
added
the
CherryPick/Approved
chenilim
added a commit
that referenced
this pull request
Feb 15, 2022
chenilim
added
the
CherryPick/Done
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Implement the new (for Big Sur) WKDownloadDelegate to handle downloads. Note that this bumps the macOS requirement to 11.3 (up from 10.14).
Ticket Link
#2333