Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Idea: Add --config flag and environment variable to set the config file #1256

Closed
jespino opened this issue Sep 20, 2021 · 3 comments · Fixed by #1418
Closed

Feature Idea: Add --config flag and environment variable to set the config file #1256

jespino opened this issue Sep 20, 2021 · 3 comments · Fixed by #1418
Assignees
Labels
Enhancement New feature or request Hacktoberfest Help Wanted Extra attention is needed

Comments

@jespino
Copy link
Contributor

jespino commented Sep 20, 2021

Summary:
Sometimes you don't want to have the config file in the same place you execute your binary, so having the posibility of specifying the config file through a parameter or through an environment variable can help to address that use case. Also some distrubtions, operating systems, or containers systems can take advantage of that parameter/environment to adapt it to its own requirements.

How important this is to me and why:

Importance: Medium

Use cases:

  • Docker storing the config file in /run/secrets
  • A Linux distribution storing the config file in /etc/focalboard.
@jespino jespino added the Enhancement New feature or request label Sep 20, 2021
@chenilim chenilim added Help Wanted Extra attention is needed Up for grabs Looking for a contributor to fix it labels Sep 20, 2021
@chenilim
Copy link
Contributor

Agree the config file path should be configurable as a parameter. Putting it up for grabs.

@achie27
Copy link
Contributor

achie27 commented Oct 2, 2021

I will be grabbing this.

@jespino
Copy link
Contributor Author

jespino commented Oct 4, 2021

@achie27 Great! thanks!

harshilsharma63 pushed a commit that referenced this issue Oct 26, 2021
* feat: adds support for --config

* feat: adds support for configFilePath in startServer

* chore: removes ugly spacing
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement New feature or request Hacktoberfest Help Wanted Extra attention is needed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants