feat: use rustls instead of openssl #581
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
itegulov
force-pushed
the
daniyar/enforce-rustls
branch
from
97d9097 to
89e4783
Compare
This reverts commit 89e4783.
|
Tested that the modified workflow works here: https://github.com/matter-labs/anvil-zksync/actions/runs/13171548653 Also, tested that x86_64/aarch64 binaries work fine with bare ubuntu:24.04 container (both |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What 💻
This PR drops openssl from dependency tree in favor of rustls. Needs matter-labs/zksync-era#3568 to be merged first and a subsequent zksync-era release to be cut after that. Opening a PR now so we don't forget about this.
Another important change in this PR is getting rid of cross. IMHO no reason to use it if we are not linking with anything other than glibc (and even that is unnecessary, see my comment in GHA workflow). Also, it is borderline unmaintained as they have been struggling to update their Docker images from
ubuntu:20.04for many years.Why ✋
Statically linking openssl is error-prone, also anvil uses rustls over openssl too