chore: remove tracing::info usage
#578
Conversation
…-zksync into db/remove-tracing-info
…-zksync into db/remove-tracing-info
|
@itegulov based on the proposal feedback, I turned off For revert / halts and logs in formatter.rs those will be subsequently updated in #571 and #577. |
|
|
||
| [dependencies] | ||
| anstream.workspace = true | ||
| anstyle.workspace = true |
| let prefix = if self.should_color() { | ||
| format!("{}Warning:{} ", WARN, Reset) | ||
| } else { | ||
| "Warning: ".to_string() | ||
| }; | ||
| self.println_err(&format!("{}{}", prefix, msg)) |
There was a problem hiding this comment.
Nit (here and in other places): extra allocations seem unjustified, we could easily just write to stdout/stderr.
Not that it's a performance concern, just feels not very clean. In that regard, I like foundry approach more.
| @@ -55,7 +56,7 @@ impl InMemoryNode { | |||
| message | |||
| ); | |||
|
|
|||
| tracing::info!("{}", pretty_message.on_red()); | |||
| sh_eprintln!("\n{}", pretty_message.on_red()); | |||
There was a problem hiding this comment.
Here and in other places: why do we need \n to be inserted manually?
What 💻
tracing::info!in favour of shell wrapper and macro usage. A simplified version of Foundry's shell wrapper.Why ✋
tracing::info!with stdout #435Evidence 📷
Include screenshots, screen recordings, or
consoleoutput here demonstrating that your changes work as intended