Skip to content

Commit

Permalink
3085: Move to Review (ethereum#3325)
Browse files Browse the repository at this point in the history
* Update 3085 status to Review

* Remove reference to EIP-1102

* Address review feedback
  • Loading branch information
rekmarks authored Mar 6, 2021
1 parent 94eea15 commit 1192e96
Showing 1 changed file with 4 additions and 7 deletions.
11 changes: 4 additions & 7 deletions EIPS/eip-3085.md
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ eip: 3085
title: Wallet Add Ethereum Chain RPC Method (`wallet_addEthereumChain`)
author: Erik Marks (@rekmarks), Pedro Gomes (@pedrouid)
discussions-to: https://ethereum-magicians.org/t/eip-3085-wallet-addethereumchain/5469
status: Draft
status: Review
type: Standards Track
category: Interface
created: 2020-11-01
Expand All @@ -21,8 +21,6 @@ The caller must specify a chain ID and some chain metadata.
The wallet application may arbitrarily refuse or accept the request.
`null` is returned if the chain was added, and an error otherwise.

Important cautions for implementers of this method are included in the [Security Considerations](#security-considerations) section.

## Motivation

All dapps require the user to interact with one or more Ethereum chains in order to function.
Expand Down Expand Up @@ -89,9 +87,9 @@ HTTPS **SHOULD** always be used over HTTP.

The method **MUST** return `null` if the request was successful, and an error otherwise.

A request for a chain that was already added **SHOULD** be considered successful.
A request to add a chain that was already added **SHOULD** be considered successful.

The wallet **SHOULD NOT** allow the same `chainId` to be added multiple times.
The wallet **MUST NOT** allow the same `chainId` to be added multiple times.
See [Security Considerations](#security-considerations) for more information.

### Examples
Expand Down Expand Up @@ -206,7 +204,7 @@ The wallet should:
- See the next section for how to handle multiple RPC endpoints.
- Only use the submitted chain ID to sign transactions, **never** a chain ID received from an RPC endpoint.
- A malicious or faulty endpoint could return arbitrary chain IDs, and potentially cause the user to sign transactions for unintended chains.
- Verify that the specified chain ID matches the return value of `eth_chainId` from the endpoint, as described in [this specification](#parameters).
- Verify that the specified chain ID matches the return value of `eth_chainId` from the endpoint, as described [above](#parameters).

### RPC Endpoints and RPC URLs

Expand Down Expand Up @@ -236,7 +234,6 @@ A chain should never be added without the explicit consent of the user, and diff
In service of these goals, the wallet should:

- When receiving a `wallet_addEthereumChain` request, display a confirmation informing the user that a specific requester has requested that the chain be added.
- The confirmation used in [EIP-1102](./eip-1102.md) may serve as a point of reference.
- Ensure that any chain metadata, such as `nativeCurrency` and `blockExplorerUrls`, are validated and used to maximum effect in the UI.
- If any images are provided via `iconUrls`, ensure that the user understands that the icons could misrepresent the actual chain added.
- If the wallet UI has a concept of a "currently selected" or "currently active" chain, ensure that the user understands when a chain added using `wallet_addEthereumChain` becomes selected.
Expand Down

0 comments on commit 1192e96

Please sign in to comment.