Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fair warning: I've never worked with any modern frameworks or really written much code recently so it's entirely possible I've done something the wrong way. I just think this is a great project and I wanted to try and contribute. If this is no good I won't be offended!
This change adds a "Remember password" option to the password screen which writes the password to localStorage and loads it again when the page is refreshed. It would likely help with #16 as well as generally being useful.
In my mind this is an acceptable level of security as the password is only saved locally on the device and accessible by the same origin however it is in plaintext in localStorage. Presumably the password is also stored in the mobile apps in a similar way.
If it's unacceptable I could see an improvement being the server storing a unique key for the user which it sends and is used to encrypt/decrypt the password. That would mean that if not logged into Nextcloud or otherwise offline the password would be inaccessible. This seemed slightly beyond my initial attempt (working out DB migrations etc) but maybe is required?
Another option would be just saving in sessionStorage rather than localStorage.