Don't reuse HttpClient for osu!api requests

matte-ek · Jul 28, 2023 · 99eb4b0 · 99eb4b0
1 parent 83ea951
commit 99eb4b0
Showing 1 changed file with 4 additions and 5 deletions.
diff --git a/BanchoMultiplayerBot/OsuApi/OsuApiWrapper.cs b/BanchoMultiplayerBot/OsuApi/OsuApiWrapper.cs
@@ -11,28 +11,27 @@ namespace BanchoMultiplayerBot.OsuApi;
 /// </summary>
 public class OsuApiWrapper
 {
-    private static readonly HttpClient Client = new();
     private readonly string _osuApiKey;
     private readonly Bot _bot;
 
     public OsuApiWrapper(Bot bot, string osuApiKey)
     {
         _bot = bot;
         _osuApiKey = osuApiKey;
-
-        Client.Timeout = TimeSpan.FromSeconds(5);
     }
 
     public async Task<BeatmapModel?> GetBeatmapInformation(int beatmapId, int mods = 0)
     {
+        using var httpClient = new HttpClient();
         using var _ = _bot.RuntimeInfo.Statistics.ApiRequestTime.NewTimer();
 
         _bot.RuntimeInfo.Statistics.ApiRequests.Inc();
 
+        httpClient.Timeout = TimeSpan.FromSeconds(5);
+
         try
         {
-            var result =
-                await Client.GetAsync($"https://osu.ppy.sh/api/get_beatmaps?k={_osuApiKey}&b={beatmapId}&mods={mods}");
+            var result = await httpClient.GetAsync($"https://osu.ppy.sh/api/get_beatmaps?k={_osuApiKey}&b={beatmapId}&mods={mods}");
 
             if (!result.IsSuccessStatusCode)
             {