Encrypted properties #49
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ategies and what options should be made available.
…ategies and what options should be made available.
…ategies and what options should be made available. (reverted from commit f1a7a4b)
leekelleher
approved these changes
May 28, 2018
There was a problem hiding this comment.
As discussed on Skype, having the encryption/decryption in the mapping code is fine.
We discussed whether this could be done at repository-level APIs, but that has additional complexities.
Although I don't have full knowledge of the Fluidity codebase, I am happy with this implementation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the ability to define encrypted properties for which their value is Encrypted/Decrypted on write/read. Properties are configured at the collection level via the following API.
collectionConfig.AddEncryptedProperty(p => p.Email);I'm not sure if there should be a better way place to put the logic for the encrypting / decrypting as it all happens in the mapping atm. Would love some feedback.