Docs updates + Inconsistant casing change of MakeReadOnly #40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
minor typo in `IEnumerable<object>`; previously read `IEnumrable<object>`
Update 02-api-10-repositories.md
Update 03-property-editors-00-entity-picker.md
makeReadonly() to MakeReadOnly() to match documentation
Update FluidityEditorFieldConfig`T.cs
method typo, replaced semi-colon with opening curly bracket,
Update 02-api-10-repositories.md
mattbrailsford
previously requested changes
Apr 10, 2018
| @@ -160,7 +160,7 @@ public FluidityEditorFieldConfig(Expression<Func<TEntityType, TValueType>> prope | |||
| /// Makes the the field readonly, disabling editing in the UI. | |||
| /// </summary> | |||
| /// <returns>The editor field configuration.</returns> | |||
| public FluidityEditorFieldConfig<TEntityType, TValueType> MakeReadonly() | |||
| public FluidityEditorFieldConfig<TEntityType, TValueType> MakeReadOnly() | |||
| { | |||
| //TODO: Create defaults for different primitives | |||
| return MakeReadonly(type => type?.ToString()); | |||
There was a problem hiding this comment.
Needs changing to MakeReadOnly too as currently breaking the build.
mattbrailsford
added a commit
that referenced
this pull request
Apr 10, 2018
mattbrailsford
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Except the
MakeReadonly()toMakeReadOnly()typo, this should probably be actioned further in order to maintain backwards compatibility.