IMO, after scheduling, the outgoingElements must contain the shipment.

matsim-vsp · Aug 14, 2024 · caa9e38 · caa9e38
1 parent a0f4e18
commit caa9e38
Show file tree

Hide file tree

Showing 4 changed files with 8 additions and 8 deletions.
diff --git a/...va/org/matsim/freight/logistics/resourceImplementations/FirstReloadLSPSchedulingTest.java b/...va/org/matsim/freight/logistics/resourceImplementations/FirstReloadLSPSchedulingTest.java
@@ -270,8 +270,8 @@ public void testFirstReloadLSPScheduling() {
 				}
 			}
 			assertTrue(handledByTranshipmentHub);
-			//This asserts that the shipments waiting for handling have been handled and the queues have been cleared
-			assertFalse(element.getOutgoingShipments().getLspShipmentsWTime().contains(shipment));
+
+			assertTrue(element.getOutgoingShipments().getLspShipmentsWTime().contains(shipment));
 			assertFalse(element.getIncomingShipments().getLspShipmentsWTime().contains(shipment));
 		}
 

diff --git a/...ight/logistics/resourceImplementations/MultipleShipmentsFirstReloadLSPSchedulingTest.java b/...ight/logistics/resourceImplementations/MultipleShipmentsFirstReloadLSPSchedulingTest.java
@@ -269,8 +269,8 @@ public void testFirstReloadLSPScheduling() {
 				}
 			}
 			assertTrue(handledByTranshipmentHub);
-			//This asserts that the shipments waiting for handling have been handled and the queues have been cleared
-			assertFalse(element.getOutgoingShipments().getLspShipmentsWTime().contains(shipment));
+
+			assertTrue(element.getOutgoingShipments().getLspShipmentsWTime().contains(shipment));
 			assertFalse(element.getIncomingShipments().getLspShipmentsWTime().contains(shipment));
 		}
 

diff --git a/...ght/logistics/resourceImplementations/MultipleShipmentsSecondReloadLSPSchedulingTest.java b/...ght/logistics/resourceImplementations/MultipleShipmentsSecondReloadLSPSchedulingTest.java
@@ -379,7 +379,7 @@ public void testSecondReloadLSPScheduling() {
 			}
 			assertTrue(handledByTranshipmentHub);
 
-			assertFalse(element.getOutgoingShipments().getLspShipmentsWTime().contains(shipment));
+			assertTrue(element.getOutgoingShipments().getLspShipmentsWTime().contains(shipment));
 			assertFalse(element.getIncomingShipments().getLspShipmentsWTime().contains(shipment));
 		}
 
@@ -406,7 +406,7 @@ public void testSecondReloadLSPScheduling() {
 			}
 			assertTrue(handledByTranshipmentHub);
 
-			assertFalse(element.getOutgoingShipments().getLspShipmentsWTime().contains(shipment));
+			assertTrue(element.getOutgoingShipments().getLspShipmentsWTime().contains(shipment));
 			assertFalse(element.getIncomingShipments().getLspShipmentsWTime().contains(shipment));
 		}
 

diff --git a/...a/org/matsim/freight/logistics/resourceImplementations/SecondReloadLSPSchedulingTest.java b/...a/org/matsim/freight/logistics/resourceImplementations/SecondReloadLSPSchedulingTest.java
@@ -379,7 +379,7 @@ public void testSecondReloadLSPScheduling() {
 			}
 			assertTrue(handledByTranshipmentHub);
 
-			assertFalse(element.getOutgoingShipments().getLspShipmentsWTime().contains(shipment));
+			assertTrue(element.getOutgoingShipments().getLspShipmentsWTime().contains(shipment));
 			assertFalse(element.getIncomingShipments().getLspShipmentsWTime().contains(shipment));
 		}
 
@@ -406,7 +406,7 @@ public void testSecondReloadLSPScheduling() {
 			}
 			assertTrue(handledByTranshipmentHub);
 
-			assertFalse(element.getOutgoingShipments().getLspShipmentsWTime().contains(shipment));
+			assertTrue(element.getOutgoingShipments().getLspShipmentsWTime().contains(shipment));
 			assertFalse(element.getIncomingShipments().getLspShipmentsWTime().contains(shipment));
 		}