Inline xml writing into Event class #3539
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current XML event writer is very inefficient. For every event that needs to be written:
This PR moves the serialization code to the events itself and makes use of a StringBuilder.
Event classes are responsible to write their xml representation via
writeAsXML(StringBuilder out)
directly to the builder. Using this approach, not a single new object needs to be allocated for writing an event.Events who don't overwrite this method will use the old behavior. The resulting output should be 100% identical.
For now
writeAsXML
was implemented for the most often used events and more may be added in further PRs.In a quick test on a realistic but not terrible large scenario, the mobsim was roughly speed up by 10%.