This repository has been archived by the owner on Mar 19, 2022. It is now read-only.
Generate JSON in pretty form, and add ip address #360
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -114,7 +156,17 @@ def test_generates_a_node_config_with_specified_run_list_and_attributes | |||
| run_list = 'recipe[baz]' | |||
| cmd = command(@host, "--run-list=#{run_list}", "--json-attributes={#{foo_json}}") | |||
| cmd.generate_node_config | |||
| assert_match "{#{foo_json},\"run_list\":[\"#{run_list}\"]}", cmd.node_config.read | |||
|
|
|||
| expected_hash = { | |||
There was a problem hiding this comment.
This repeated pattern in the test has a bit of smell to it. Thinking we should have some sort of helper here that allows for testing only the part of the json we're interested in for a given test.
There was a problem hiding this comment.
I felt the same way. I'll refactor this. I was thinking something like
assert_config_contains expected_hash, cmd
There was a problem hiding this comment.
Cool, you can see the updated code below
matschaffer
added a commit
that referenced
this pull request
Apr 26, 2014
Generate JSON in pretty form, and add ip address
|
Thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Store the IP address from the node in the node file. Also, pretty print the JSON so it's easier to manipulate.