Skip to content
This repository has been archived by the owner on Mar 19, 2022. It is now read-only.

Explicitly set root path for default *_path options #308

Merged
merged 2 commits into from
Nov 9, 2013
Merged

Explicitly set root path for default *_path options #308

merged 2 commits into from
Nov 9, 2013

Commits on Nov 8, 2013

  1. Explicitly set root path for default *_path options 

    Chef 11.8.0 (with mixlib-config 2.0) sets `*_path` options by default
based on `cookbook_path`. If it is an array (as always in knife-solo),
the other paths are also arrays. And matschaffer#300 will catch that and error out.

While the conversion to Array is a regression in Chef itself, we anyway
want to set the default path relative to our kitchen root, as
`cookbook_path` components might be pointing to somewhere else.
    @tmatilai
    tmatilai committed Nov 8, 2013
    Configuration menu
    Copy the full SHA
    2c131bf View commit details
    Browse the repository at this point in the history

  2. Verify that node_path is a String 

    `node_path` made it back to Chef's default configuration in 11.8.0. And
as pre 0.3.0 setups won't normally have it explicitly configured, it
defaults to being an Array.

Also a user might set it to be an Array, which leads knife-solo crashing
with the infamous `ERROR: TypeError: no implicit conversion of Array
into String`. This escaped from us in matschafferGH-300.
    @tmatilai
    tmatilai committed Nov 8, 2013
    Configuration menu
    Copy the full SHA
    9b76803 View commit details
    Browse the repository at this point in the history