Memory leak fix #736
Merged
Memory leak fix #736
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
leaanthony
commented
Jun 29, 2021
leaanthony
commented
- Fixes a number of memory leaks. Significant reduction in memory usage.
- Refactored project layout to align with latest Wails.
Closed
matryer
reviewed
Jun 29, 2021
app/app.go
Outdated
| Type: dialog.InfoDialog, | ||
| Title: "You're up to date", | ||
| Message: fmt.Sprintf("%s is the latest version.", latest.TagName), | ||
| Buttons: []string{"OK"}, | ||
| CancelButton: "OK", | ||
| }) | ||
| if err != nil { | ||
| // @matryer - how do you want to handle these errors? |
There was a problem hiding this comment.
not much we can do if these error is there?
There was a problem hiding this comment.
100% safe to ignore in this context. The error is mainly for text that cannot be converted to UTF-16.
|
Thank you very much for taking the time to iron this issue out. The effort is greatly appreciated. 👍 |
|
No worries! I managed to get it down to 32bytes of leakage and that was coming from foundation internals. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.